Thread (70 messages) 70 messages, 13 authors, 2023-11-07

Re: [PATCH v2 17/20] arm64: dts: google: Add initial Google gs101 SoC support

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2023-10-11 07:50:15
Also in: linux-devicetree

On Tue, Oct 10, 2023 at 11:49:25PM +0100, Peter Griffin wrote:
+		serial_0: serial@10a00000 {
+			compatible = "google,gs101-uart";
You use this entry, but:
+			reg = <0x0 0x10a00000 0xc0>;
+			reg-io-width = <4>;
+			samsung,uart-fifosize = <256>;
See, it's really the samsung IP block.  Please don't declare new
compatible entries when you don't need to, it just adds churn to the
kernel for no reason (and makes you do more work.)

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help