Re: [PATCH 19/21] google/gs101: Add dt overlay for oriole board
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2023-10-06 07:08:58
Also in:
linux-clk, linux-devicetree, linux-gpio, linux-samsung-soc, linux-watchdog
Hi Peter, On Thu, Oct 5, 2023 at 5:58 PM Peter Griffin [off-list ref] wrote:
The LK bootloader on Pixel6 searches for a dt overlay in the dtbo partition with a board_id and board_rev that matches what is baked into the device. If this overlay is not present then the phone will bootloop in fastboot and you can't boot the upstream kernel. This commit adds a dtbo for the production oriole variant. The other pre-production board overlays are not included at this time. Adding the dtbo here allows for a better experience when building/booting the upstream kernel on Pixel devices as all the DT required to boot the device will be created as part of the kernel build process. Rather than having to fetch the dtbo from some other repo. Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/arch/arm64/boot/dts/google/gs101-oriole.dtso@@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Oriole DVT Device Tree + * + * Copyright 2021-2023 Google,LLC + */ + +/dts-v1/; +/plugin/; + +/ { + board_id = <0x20304>; + board_rev = <0x10000>; + fragment@boardbase { + target-path="/"; + __overlay__ { + model = "Oriole DVT"; + compatible = "google,gs101-oriole"; + }; + };
Please use sugar-syntax instead of manually defining
fragment/target-path/__overlay__ constructs.
You can override these properties in the root node of the base DTS
using the much simpler:
&{/} {
model = "Oriole DVT";
compatible = "google,gs101-oriole";
};
The generated DTBO should be identical (modulo naming).
+};
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel