Re: [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible string
From: Frank Li <Frank.li@nxp.com>
Date: 2023-10-16 20:11:20
Also in:
imx, linux-devicetree, linux-i3c, lkml
On Mon, Oct 16, 2023 at 09:57:18PM +0200, Krzysztof Kozlowski wrote:
On 16/10/2023 21:32, Frank Li wrote:quoted
On Mon, Oct 16, 2023 at 06:30:11PM +0100, Conor Dooley wrote:quoted
On Mon, Oct 16, 2023 at 11:24:49AM -0400, Frank Li wrote:quoted
In driver, compatible string is silvaco,i3c-master instead of silvaco,i3c-master-v1.And what makes the driver right & the binding wrong? AFAICT, this is an IP sold by silvaco & the -v1 suffix was explicitly requested during review of the binding.The driver existed for the long time. DTS files already use silvaco,i3c-master. There are two options, one change doc, the other change dts and drivers. I think change doc is easiest ways. If there are v2 in future, we can added silvaco,i3c-master-v2 in future. If everyone prefer change drivers and dts, I can work on new patch. Just break back compatiblity.No, because Rob explicitly pointed out too generic name. https://lore.kernel.org/all/20210111200821.GA2978830@robh.at.kernel.org/ (local) Is it some way to avoid implementing feedback or how does it work?
Downstream use silvaco,i3c-master to match driver. Anyways, miss match happened. option 1: fix doc option 2: fix driver and dts what do you perfer?
Best regards, Krzysztof
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel