Thread (24 messages) 24 messages, 3 authors, 2023-08-21

Re: [PATCH -next 08/11] gpio: omap: Use helper function devm_clk_get_prepared()

From: Andy Shevchenko <andy@kernel.org>
Date: 2023-08-18 15:01:09
Also in: linux-gpio, linux-omap, linux-pwm

On Fri, Aug 18, 2023 at 05:30:15PM +0800, Li Zetao wrote:
Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for
prepared and enabled clocks"), devm_clk_get() and clk_prepare() can now be
replaced by devm_clk_get_prepared() when the driver enables (and possibly
prepares) the clocks for the whole lifetime of the device. Moreover, it is
no longer necessary to unprepare and disable the clocks explicitly.
The commit message isn't correct. Seems you copied'n'pasted from other cases.

Please, revisit.

Code wise looks legit to me.

With the commit message fixed
Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help