Thread (24 messages) 24 messages, 3 authors, 2023-08-21

Re: [PATCH -next 01/11] gpio: cadence: Use helper function devm_clk_get_enabled()

From: Andy Shevchenko <andy@kernel.org>
Date: 2023-08-18 13:50:42
Also in: linux-gpio, linux-omap, linux-pwm

On Fri, Aug 18, 2023 at 05:30:08PM +0800, Li Zetao wrote:
Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for
prepared and enabled clocks"), devm_clk_get() and clk_prepare_enable()
can now be replaced by devm_clk_get_enabled() when the driver enables
(and possibly prepares) the clocks for the whole lifetime of the device.
Moreover, it is no longer necessary to unprepare and disable the clocks
explicitly.
...
-			"Failed to retrieve peripheral clock, %d\n", ret);
+			"Failed to retrieve and enable peripheral clock, %d\n",
In some drivers you changed the message in some not.
I suggest to avoid changing messages for now and do this separately.
Also consider switching them to use dev_err_probe() instead.

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help