On Wed, Aug 16, 2023 at 11:06:51AM +0530, Sriranjani P wrote:

quoted

-----Original Message-----
From: Rob Herring [mailto:robh@kernel.org]
Sent: 14 August 2023 19:03
To: Sriranjani P <redacted>
Cc: edumazet@google.com; linux-kernel@vger.kernel.org;
alexandre.torgue@foss.st.com; ravi.patel@samsung.com;
alim.akhtar@samsung.com; linux-samsung-soc@vger.kernel.org; linux-
fsd@tesla.com; conor+dt@kernel.org; mcoquelin.stm32@gmail.com;
kuba@kernel.org; netdev@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; pabeni@redhat.com; robh+dt@kernel.org;
pankaj.dubey@samsung.com; richardcochran@gmail.com;
krzysztof.kozlowski+dt@linaro.org; joabreu@synopsys.com;
devicetree@vger.kernel.org; davem@davemloft.net;
swathi.ks@samsung.com
Subject: Re: [PATCH v3 1/4] dt-bindings: net: Add FSD EQoS device tree
bindings


On Mon, 14 Aug 2023 16:55:36 +0530, Sriranjani P wrote:

quoted

Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
Ethernet YAML schema to enable the DT validation.

Signed-off-by: Pankaj Dubey <redacted>
Signed-off-by: Ravi Patel <redacted>
Signed-off-by: Swathi K S <redacted>
Signed-off-by: Sriranjani P <redacted>
---
 .../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
 .../devicetree/bindings/net/tesla,ethqos.yaml | 114
++++++++++++++++++
 2 files changed, 117 insertions(+), 2 deletions(-)  create mode
100644 Documentation/devicetree/bindings/net/tesla,ethqos.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-
ci/linux/Documentation/devicetree/bindings/net/tesla,ethqos.yaml:
properties:clock-names: {'minItems': 5, 'maxItems': 10, 'items': [{'const':
'ptp_ref'}, {'const': 'master_bus'}, {'const': 'slave_bus'}, {'const': 'tx'}, {'const':
'rx'}, {'const': 'master2_bus'}, {'const': 'slave2_bus'}, {'const':
'eqos_rxclk_mux'}, {'const': 'eqos_phyrxclk'}, {'const':
'dout_peric_rgmii_clk'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: https://protect2.fireeye.com/v1/url?k=f50e335d-
aa950a44-f50fb812-000babff3793-de26ea17ef025418&q=1&e=897786e4-
5f9b-40d8-8a7f-399cb69c7ee8&u=http%3A%2F%2Fdevicetree.org%2Fmeta-
schemas%2Fitems.yaml%23
Documentation/devicetree/bindings/net/tesla,ethqos.example.dtb:
/example-0/ethernet@14300000: failed to match any schema with
compatible: ['tesla,dwc-qos-ethernet-4.21']

Thanks for review. Will fix this in v4.

It's not a review. It's an automated reply running what you should have 
run yourself...

quoted

doc reference errors (make refcheckdocs):

See https://protect2.fireeye.com/v1/url?k=ccb7f6d0-932ccfc9-ccb67d9f-
000babff3793-2137ac63fe6ddef8&q=1&e=897786e4-5f9b-40d8-8a7f-
399cb69c7ee8&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fdev
icetree-bindings%2Fpatch%2F20230814112539.70453-2-
sriranjani.p%40samsung.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

Sorry, I could not get this comment, can you elaborate this. 

The automated tests apply patches to the latest rc1 tag. Patches which 
apply, but have some other dependency may have warnings. If you have 
such a dependency, you should note it in the patch (below the '---').

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel