Re: [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC
From: Joel Stanley <joel@jms.id.au>
Date: 2023-08-09 08:05:44
Also in:
linux-aspeed, linux-devicetree, lkml
On Tue, 8 Aug 2023 at 08:43, Delphine CC Chiu [off-list ref] wrote:
Add linux device tree entry related to Yosemite 4 specific devices connected to BMC SoC.
Convention is to mention what kind of machine this is, to give us some context for review. "This is an x86 server" or similar. Take a look at existing aspeed device tree commits for inspiration.
+&mac2 {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_rmii3_default>;
+ no-hw-checksum;
+ use-ncsi;
+ mlx,multi-host;
+ ncsi-ctrl,start-redo-probe;
+ ncsi-ctrl,no-channel-monitor;
+ ncsi-package = <1>;
+ ncsi-channel = <1>;
+ ncsi-rexmit = <1>;
+ ncsi-timeout = <2>;None of these are properties that mainline Linux supports. Do you plan on sending patches for these?
+};
+
+&mac3 {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_rmii4_default>;
+ no-hw-checksum;
+ use-ncsi;
+ mlx,multi-host;
+ ncsi-ctrl,start-redo-probe;
+ ncsi-ctrl,no-channel-monitor;
+ ncsi-package = <1>;
+ ncsi-channel = <1>;
+ ncsi-rexmit = <1>;
+ ncsi-timeout = <2>;
+};_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel