Re: [PATCH v2 3/3] media: exynos4-is: fimc-is: replace duplicate pmu node with phandle
From: Krzysztof Kozlowski <hidden>
Date: 2023-08-08 19:55:36
Also in:
linux-devicetree, linux-media, linux-samsung-soc, lkml
On 08/08/2023 01:13, Andi Shyti wrote:
Hi Krzysztof, [...]quoted
+static void __iomem *fimc_is_get_pmu_regs(struct device *dev) +{ + struct device_node *node; + void __iomem *regs; + + node = of_parse_phandle(dev->of_node, "samsung,pmu-syscon", 0); + if (!node) { + dev_warn(dev, "Finding PMU node via deprecated method, update your DTB\n"); + node = of_get_child_by_name(dev->of_node, "pmu"); + if (!node) + return IOMEM_ERR_PTR(-ENODEV);in my opinion this should be: ... if (!node) return IOMEM_ERR_PTR(-ENODEV); dev_warn(dev, "Finding PMU node via deprecated method, update your DTB\n"); Because if you don't have both "samsung,pmu-syscon and "pmu" then the warning should not be printed and you need to return -ENODEV.
Why not? Warning is correct - the driver is trying to find, thus continuous tense "Finding", PMU node via old method.
... and... "*please* update your DTB", the user might get upset and out of sheer spite, decides not to do it – just because! :)
The message is already long enough, why making it longer? Anyone who ships DTS outside of Linux kernel is doomed anyway... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel