Thread (29 messages) 29 messages, 6 authors, 2023-08-14
STALE1075d
Revisions (3)
  1. v1 [diff vs current]
  2. v2 [diff vs current]
  3. v3 current

[PATCH v3 0/9] Use dev_err_probe in i2c probe function

From: Liao Chang <hidden>
Date: 2023-08-08 01:30:28
Also in: linux-arm-msm, linux-i2c, lkml

Use the dev_err_probe function instead of dev_err in the probe function
so that the printed messge includes the return value and also handles
-EPROBE_DEFER nicely.

NOTICE: dev_err_probe always print the second parameter that happens to
be the return value, hence the return errno will be removed from the
third parameter to avoid a redundant error message.

v3:
Convert all dev_err() in synquacer_i2c_probe() to dev_err_probe()
even if the return value is known to never be -EPROBE_DEFER.

v2:
1. Convert all dev_err() in lpi2c_imx_probe(), synquacer_i2c_probe(),
   mlxbf_i2c_probe() to dev_err_probe().
2. Add Reviewed-by: Florian Fainelli [off-list ref]
3. Add Reviewed-by: Yicong Yang [off-list ref]
4. Add Reviewed-by: Andi Shyti [off-list ref]

Liao Chang (9):
  i2c: bcm2835: Use dev_err_probe in probe function
  i2c: mlxbf: Use dev_err_probe in probe function
  i2c: xlp9xx: Use dev_err_probe in probe function
  i2c: hisi: Use dev_err_probe in probe function
  i2c: qcom-cci: Use dev_err_probe in probe function
  i2c: pxa: Use dev_err_probe in probe function
  i2c: dln2: Use dev_err_probe in probe function
  i2c: imx-lpi2c: Use dev_err_probe in probe function
  i2c: synquacer: Use dev_err_probe in probe function

 drivers/i2c/busses/i2c-bcm2835.c   | 14 ++++-----
 drivers/i2c/busses/i2c-dln2.c      |  6 ++--
 drivers/i2c/busses/i2c-hisi.c      | 12 +++----
 drivers/i2c/busses/i2c-imx-lpi2c.c | 12 +++----
 drivers/i2c/busses/i2c-mlxbf.c     | 50 ++++++++++--------------------
 drivers/i2c/busses/i2c-pxa.c       |  7 ++---
 drivers/i2c/busses/i2c-qcom-cci.c  |  6 ++--
 drivers/i2c/busses/i2c-synquacer.c | 28 ++++++-----------
 drivers/i2c/busses/i2c-xlp9xx.c    |  6 ++--
 9 files changed, 50 insertions(+), 91 deletions(-)

-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help