Re: [PATCH 14/58] mmc: dw_mmc: exynos: Convert to platform remove callback returning void

On Thu, Jul 13, 2023 at 10:11:15AM +0200, Krzysztof Kozlowski wrote:

On 13/07/2023 10:07, Yangtao Li wrote:

quoted

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

You even copied Uwe's commit msg... Aren't you duplicate his work or is
it being coordinated?

We communicated and I politely asked to not interfer. This series is
just what Yangtao had still pending. That's fine for me.

Thanks for noticing,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |