Re: [PATCH 14/58] mmc: dw_mmc: exynos: Convert to platform remove callback returning void
From: Krzysztof Kozlowski <hidden>
Date: 2023-07-13 08:19:07
Also in:
linux-mmc, linux-samsung-soc, lkml
On 13/07/2023 10:07, Yangtao Li wrote:
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant.
You even copied Uwe's commit msg... Aren't you duplicate his work or is it being coordinated? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel