Thread (6 messages) 6 messages, 2 authors, 2023-06-25
STALE1109d

[PATCH] usb: ohci-at91: Fix the unhandle interrupt when resume

From: Guiting Shen <hidden>
Date: 2023-06-22 02:58:01
Also in: linux-usb, lkml
Subsystem: the rest, usb ohci driver, usb subsystem · Maintainers: Linus Torvalds, Alan Stern, Greg Kroah-Hartman

The ohci_hcd_at91_drv_suspend() sets ohci->rh_state to OHCI_RH_HALTED when
suspend which will let the ohci_irq() skip the interrupt after resume. And
nobody to handle this interrupt.

Set the ohci->rh_state to OHCI_RH_SUSPEND instead of OHCI_RH_HALTED when
suspend to fix it.

Signed-off-by: Guiting Shen <redacted>
---
 drivers/usb/host/ohci-at91.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index b9ce8d80f20b..7a970e573668 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -645,7 +645,7 @@ ohci_hcd_at91_drv_suspend(struct device *dev)
 	 * REVISIT: some boards will be able to turn VBUS off...
 	 */
 	if (!ohci_at91->wakeup) {
-		ohci->rh_state = OHCI_RH_HALTED;
+		ohci->rh_state = OHCI_RH_SUSPENDED;
 
 		/* flush the writes */
 		(void) ohci_readl (ohci, &ohci->regs->control);
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help