Hi, Guillaume:

On Mon, 2023-05-29 at 16:31 +0200, Guillaume Ranquet wrote:

 	 
External email : Please do not click links or open attachments until
you have verified the sender or the content.
 Adds hdmi and hdmi-ddc support for v2 IP.

Signed-off-by: Guillaume Ranquet <redacted>
---

[snip]

+
+static int mtk_hdmi_bridge_attach(struct drm_bridge *bridge,
+  enum drm_bridge_attach_flags flags)
+{
+struct mtk_hdmi *hdmi = hdmi_ctx_from_bridge(bridge);
+int ret;
+
+if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) {
+DRM_ERROR("The flag DRM_BRIDGE_ATTACH_NO_CONNECTOR must be
supplied\n");
+return -EINVAL;
+}
+if (hdmi->next_bridge) {
+ret = drm_bridge_attach(bridge->encoder, hdmi->next_bridge, bridge,
flags);
+if (ret)
+return ret;
+}
+
+pm_runtime_enable(hdmi->dev);
+mtk_hdmi_enable_disable(hdmi, true);

In mt8173 hdmi driver, the bridge attach function does not enable hdmi,
could you align the enable timing with mt8173? If not, please explain.

+
+return 0;
+}

This function is almost the same as mt8173 one, try to merge them.

Regards,
CK

+

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel