Hi, Guillaume:

On Mon, 2023-05-29 at 16:31 +0200, Guillaume Ranquet wrote:

 	 
External email : Please do not click links or open attachments until
you have verified the sender or the content.
 Adds hdmi and hdmi-ddc support for v2 IP.

Signed-off-by: Guillaume Ranquet <redacted>
---
 

[snip]

+
+static unsigned char vddc_read(struct mtk_hdmi_ddc *ddc, unsigned
int u4_clk_div,
+       unsigned char uc_dev, unsigned int u4_addr,

Remove the type style in naming,

u4_addr => addr

Regards,
CK

+       enum sif_bit_t_hdmi uc_addr_type,
+       unsigned char *puc_value, unsigned int u4_count)
+{
+unsigned int u4_read_count = 0;
+unsigned char uc_return_value = 0;
+
+if (!puc_value || !u4_count || !u4_clk_div ||
+    uc_addr_type > SIF_16_BIT_HDMI ||
+    (uc_addr_type == SIF_8_BIT_HDMI && u4_addr > 255) ||
+    (uc_addr_type == SIF_16_BIT_HDMI && u4_addr > 65535)) {
+return 0;
+}
+
+if (uc_addr_type == SIF_8_BIT_HDMI)
+u4_read_count = 255 - u4_addr + 1;
+else if (uc_addr_type == SIF_16_BIT_HDMI)
+u4_read_count = 65535 - u4_addr + 1;
+
+u4_read_count = (u4_read_count > u4_count) ? u4_count :
u4_read_count;
+uc_return_value = ddcm_read_hdmi(ddc, u4_clk_div, uc_dev, u4_addr,
+ uc_addr_type, puc_value, u4_read_count);
+return uc_return_value;
+}
+

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel