Thread (23 messages) 23 messages, 6 authors, 2023-06-21

Re: [PATCH v2 4/5] clk: mediatek: mt8183: Add CLK_VDEC_ACTIVE to vdec

From: Chen-Yu Tsai <wenst@chromium.org>
Date: 2023-06-08 07:44:05
Also in: linux-clk, linux-devicetree, linux-mediatek, lkml

On Thu, Jun 8, 2023 at 4:57 AM Nícolas F. R. A. Prado
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
Add the CLK_VDEC_ACTIVE clock to the vdec clock driver. This clock is
enabled by the VPU once it starts decoding.

Signed-off-by: Nícolas F. R. A. Prado <redacted>

---

Changes in v2:
- Added CLK_IGNORE_UNUSED flag

 drivers/clk/mediatek/clk-mt8183-vdec.c | 5 +++++
 include/dt-bindings/clock/mt8183-clk.h | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/mediatek/clk-mt8183-vdec.c b/drivers/clk/mediatek/clk-mt8183-vdec.c
index 513b7956cbea..03c4f1acfdb8 100644
--- a/drivers/clk/mediatek/clk-mt8183-vdec.c
+++ b/drivers/clk/mediatek/clk-mt8183-vdec.c
@@ -27,6 +27,10 @@ static const struct mtk_gate_regs vdec1_cg_regs = {
        GATE_MTK(_id, _name, _parent, &vdec0_cg_regs, _shift,   \
                &mtk_clk_gate_ops_setclr_inv)

+#define GATE_VDEC0(_id, _name, _parent, _shift)                \
+       GATE_MTK_FLAGS(_id, _name, _parent, &vdec0_cg_regs, _shift,     \
+               &mtk_clk_gate_ops_setclr, CLK_IGNORE_UNUSED)
I think what you want is a read-only gate clock only used for reading back
the status. The ops would only have .is_enabled.

ChenYu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help