Re: [PATCH v2 2/3] dt-bindings: iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC

пт, 2 июн. 2023 г. в 11:38, Krzysztof Kozlowski
[off-list ref]:
Hi Krzysztof,

On 02/06/2023 00:30, Maksim Kiselev wrote:

quoted

From: Maxim Kiselev <redacted>

Allwinner's D1/T113s/R329/T507 SoCs have a new general purpose ADC.
This ADC is the same for all of this SoCs. The only difference is
the number of available channels.

Except that it wasn't tested...

Yes, you are right. I tested it only on the T113s board. And I will be glad if
someone tests it on another SoC.

...

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

I got a warning about required maintainer property. Should I do
anything with this?
If yes, then who should be a maintainer?

...

Hm? So you do not allow anything from adc.yaml related? Are you sure
this is your intention?

I'm not sure about it. I looked at other ADC bindings and didn't find
another driver with 'additionalProperties: true'

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel