Re: [PATCH v4 12/12] ARM: entry: Make asm coproc dispatch code NWFPE only

From
Linus Walleij <hidden>
Date
2023-03-21 15:13:38
Reply to
Ard Biesheuvel, 2023-03-20
On Mon, Mar 20, 2023 at 2:19 PM Ard Biesheuvel [off-list ref] wrote:
Now that we can dispatch all VFP and iWMMXT related undef exceptions
using undef hooks implemented in C code, we no longer need the asm entry
code that takes care of this unless we are using FPE. As this means it
is ARM only, we can also remove the Thumb2 specific decorations.

It also means the non-standard, asm-only calling convention where
returning via LR means failure and returning via R9 means success is now
only used on legacy platforms that lack any kind of function return
prediction, avoiding the associated performance impact.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Clearly makes things more compartmentalized.
Reviewed-by: Linus Walleij <redacted>
quoted hunk ↗ jump to hunk
 call_fpe:
-       badr    r9, ret_from_exception
-       badr    lr, __und_usr_fault_32
+#ifdef CONFIG_FPE_NWFPE
+       adr     r9, ret_from_exception
+       adr     lr, __und_usr_fault_32
I actually have the NetWinder so if we want to refactor further I can test.
Marc Zyngier has this machine too.

Scott Bambrough wrote the NWFPE handling a long time ago I think, so
putting him on CC for fun.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (32 messages) 32 messages, 6 authors, last reply 2023-04-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help