Re: [PATCH v4 10/12] ARM: entry: Disregard Thumb undef exception in coproc dispatch

From
Linus Walleij <hidden>
Date
2023-03-21 15:07:30
Reply to
Ard Biesheuvel, 2023-03-20
On Mon, Mar 20, 2023 at 2:19 PM Ard Biesheuvel [off-list ref] wrote:
Now that the only remaining coprocessor instructions being handled via
the dispatch in entry-armv.S are ones that only exist in a ARM (A32)
encoding, we can simplify the handling of Thumb undef exceptions, and
send them straight to the undefined instruction handlers in C code.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
I gave up trying to follow the code because the diff gets really convoluted.

But the mere relief of getting rid of things like this terse thing:
-       .pushsection __ex_table,"a"
-       .long   1b, 4b
-#if CONFIG_ARM_THUMB && __LINUX_ARM_ARCH__ >= 6 && CONFIG_CPU_V7
-       .long   2b, 4b
-       .long   3b, 4b
-#endif
Make it worth it, so as long as it works I'm game.
Acked-by: Linus Walleij <redacted>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (32 messages) 32 messages, 6 authors, last reply 2023-04-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help