Re: [PATCH 08/20] dt-bindings: pinctrl: ralink: add new compatible strings
From: Rob Herring <robh@kernel.org>
Date: 2023-03-08 21:00:27
Also in:
linux-devicetree, linux-gpio, linux-mediatek, linux-mips, lkml
On Fri, Mar 03, 2023 at 03:28:37AM +0300, arinc9.unal@gmail.com wrote:
quoted hunk ↗ jump to hunk
From: Arınç ÜNAL <redacted> Add the new mediatek compatible strings. Change the compatible string on the examples with the mediatek compatible strings. Add the new compatible strings for mt7620, mt76x8, and rt305x to be able to properly document the pin muxing information of each SoC, or SoCs that use the same pinmux data. Signed-off-by: Arınç ÜNAL <redacted> --- .../devicetree/bindings/pinctrl/ralink,mt7620-pinctrl.yaml | 7 +++++-- .../devicetree/bindings/pinctrl/ralink,mt7621-pinctrl.yaml | 6 ++++-- .../devicetree/bindings/pinctrl/ralink,rt305x-pinctrl.yaml | 5 ++++- 3 files changed, 13 insertions(+), 5 deletions(-)diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,mt7620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,mt7620-pinctrl.yaml index cde6de77e228..a94d2e7a5f37 100644 --- a/Documentation/devicetree/bindings/pinctrl/ralink,mt7620-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/ralink,mt7620-pinctrl.yaml@@ -17,7 +17,10 @@ description: properties: compatible: - const: ralink,mt7620-pinctrl + enum: + - mediatek,mt7620-pinctrl + - mediatek,mt76x8-pinctrl + - ralink,mt7620-pinctrl
To repeat the options from last time:
Carrying both strings is a NAK. Either you (and everyone using these platforms) care about the ABI and are stuck with the "wrong" string. In the end, they are just unique identifiers. Or you don't care and break the ABI and rename everything. If you do that, do just that in your patches and make it crystal clear in the commit msg that is your intention and why that is okay.
Marketing/acquistion renames was just an example and common reason. That doesn't make other reasons okay. I don't see any reason given here. If you want to break the ABI (do you??, because the commit message still doesn't say), then you don't need "ralink,mt7620-pinctrl". Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel