Re: [PATCH 04/23] interconnect: imx: fix registration race
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
Date: 2023-02-03 16:01:40
Also in:
linux-arm-msm, linux-pm, linux-samsung-soc, linux-tegra, lkml, stable
Hello Johan, On Wed, 1 Feb 2023 11:15:40 +0100 Johan Hovold [off-list ref] wrote:
The current interconnect provider registration interface is inherently
racy as nodes are not added until the after adding the provider. This
can specifically cause racing DT lookups to fail.
Switch to using the new API where the provider is not registered until
after it has been fully initialised.
Fixes: f0d8048525d7 ("interconnect: Add imx core driver")
Cc: stable@vger.kernel.org # 5.8
Cc: Leonard Crestez <redacted>
Cc: Alexandre Bailon <redacted>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>Georgi pointed me to this series after I reported a bug yesterday [0], that I found on iMX8MP. So I ran some tests with my original, failing tree, minus one patch with my debugging code to hunt for the bug, plus patches 1-4 of this series. The original code was failing approx 5~10% of the times. With your 4 patches applied it ran 139 times with zero errors, which looks great! I won't be able to do more testing until next Monday to be extra sure. [0] https://lore.kernel.org/linux-arm-kernel/20230202175525.3dba79a7@booty/T/#u (local) -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel