Thread (59 messages) 59 messages, 10 authors, 2023-03-13

Re: [PATCH 01/23] interconnect: fix mem leak when freeing nodes

From: Konrad Dybcio <hidden>
Date: 2023-02-01 11:19:13
Also in: linux-arm-msm, linux-pm, linux-samsung-soc, linux-tegra, lkml, stable


On 1.02.2023 11:15, Johan Hovold wrote:
The node link array is allocated when adding links to a node but is not
deallocated when nodes are destroyed.

Fixes: 11f1ceca7031 ("interconnect: Add generic on-chip interconnect API")
Cc: stable@vger.kernel.org      # 5.1
Cc: Georgi Djakov <redacted>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
Reviewed-by: Konrad Dybcio <redacted>

Konrad
quoted hunk ↗ jump to hunk
 drivers/interconnect/core.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index 423f875d4b54..dc61620a0191 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -850,6 +850,7 @@ void icc_node_destroy(int id)
 
 	mutex_unlock(&icc_lock);
 
+	kfree(node->links);
 	kfree(node);
 }
 EXPORT_SYMBOL_GPL(icc_node_destroy);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help