RE: [PATCH-next] crypto: aspeed: fix type warnings

From
Neal Liu <neal_liu@aspeedtech.com>
Date
2023-02-02 03:23:45
Also in
linux-aspeed, linux-crypto, lkml
Reply to
Herbert Xu, 2023-02-02
-----Original Message-----
From: Herbert Xu <herbert@gondor.apana.org.au>
Sent: Thursday, February 2, 2023 11:10 AM
To: Neal Liu <neal_liu@aspeedtech.com>
Cc: Joel Stanley <joel@jms.id.au>; Andrew Jeffery <redacted>; David
S . Miller [off-list ref]; linux-arm-kernel@lists.infradead.org;
linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
linux-crypto@vger.kernel.org
Subject: Re: [PATCH-next] crypto: aspeed: fix type warnings

On Thu, Feb 02, 2023 at 10:56:00AM +0800, Neal Liu wrote:
quoted
@@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct
aspeed_acry_dev *acry_dev, void *buf,  static int
aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev)  {
 	struct akcipher_request *req = acry_dev->req;
-	u8 *sram_buffer = (u8 *)acry_dev->acry_sram;
+	u8 *sram_buffer = (u8 __force *)acry_dev->acry_sram;
Wouldn't it be better to keep the iomem marker and then use readb on
sram_buffer?
This way works too.
I cannot tell which way is better. Do you prefer to keep the iomem marker?
Thanks

-Neal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (5 messages) 5 messages, 2 authors, last reply 2023-02-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help