Re: [PATCH-next] crypto: aspeed: fix type warnings

From
Herbert Xu <herbert@gondor.apana.org.au>
Date
2023-02-02 03:10:21
Also in
linux-aspeed, linux-crypto, lkml
Reply to
Neal Liu, 2023-02-02
On Thu, Feb 02, 2023 at 10:56:00AM +0800, Neal Liu wrote:
quoted hunk ↗ jump to hunk
@@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf,
 static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev)
 {
 	struct akcipher_request *req = acry_dev->req;
-	u8 *sram_buffer = (u8 *)acry_dev->acry_sram;
+	u8 *sram_buffer = (u8 __force *)acry_dev->acry_sram;
Wouldn't it be better to keep the iomem marker and then use readb
on sram_buffer?

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (5 messages) 5 messages, 2 authors, last reply 2023-02-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help