Re: [PATCH 5/8] dt-bindings: rtc: Add Amlogic Meson vrtc controller binding
From: Rob Herring <robh@kernel.org>
Date: 2023-01-25 19:19:58
Also in:
linux-amlogic, linux-devicetree, linux-gpio, linux-pwm, linux-rtc
On Mon, Jan 23, 2023 at 10:28:49PM +0100, Heiner Kallweit wrote:
Add Amlogic Meson vrtc controller binding.
You are not adding, you are converting.
Tested with make targets dt_binding_check and dtbs_check.
That's assumed...
quoted hunk ↗ jump to hunk
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- .../bindings/rtc/amlogic,meson-vrtc.yaml | 50 +++++++++++++++++++ .../bindings/rtc/rtc-meson-vrtc.txt | 22 -------- 2 files changed, 50 insertions(+), 22 deletions(-) create mode 100644 Documentation/devicetree/bindings/rtc/amlogic,meson-vrtc.yaml delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-meson-vrtc.txtdiff --git a/Documentation/devicetree/bindings/rtc/amlogic,meson-vrtc.yaml b/Documentation/devicetree/bindings/rtc/amlogic,meson-vrtc.yaml new file mode 100644 index 000000000..26a70b3ce --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/amlogic,meson-vrtc.yaml@@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/amlogic,meson-vrtc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic Virtual RTC (VRTC) + +maintainers: + - Neil Armstrong <neil.armstrong@linaro.org> + +description: | + This is a Linux interface to an RTC managed by firmware, hence it's + virtual from a Linux perspective. The interface is 1 register where + an alarm time (in seconds) is to be written. + The alarm register is a simple scratch register shared between the + application processors (AP) and the secure co-processor (SCP.) When + the AP suspends, the SCP will use the value of this register to + program an always-on timer before going sleep. When the timer expires, + the SCP will wake up and will then wake the AP. + +allOf: + - $ref: rtc.yaml# + +properties: + compatible: + enum: + - amlogic,meson-vrtc + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + bus@ff800000 { + reg = <0x0 0xff800000 0x0 0x100000>; + #address-cells = <2>; + #size-cells = <2>; + + rtc@a8 { + compatible = "amlogic,meson-vrtc"; + reg = <0x0 0x000a8 0x0 0x4>;
Just use 1 address/size cell here and then you don't need the bus node (which has an error in it (no ranges)). Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel