Thread (41 messages) 41 messages, 6 authors, 2022-09-23

Re: [RFC PATCH v2 19/20] nvmem: layouts: rewrite the u-boot-env driver as a NVMEM layout

From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: 2022-09-21 10:37:59
Also in: linux-devicetree, lkml

Hi Michael,

michael@walle.cc wrote on Fri,  2 Sep 2022 00:18:56 +0200:
Instead of hardcoding the underlying access method mtd_read() and
duplicating all the error handling, rewrite the driver as a nvmem
layout which just uses nvmem_device_read() and thus works with any
NVMEM device.

But because this is now not a device anymore, the compatible string
will have to be changed so the device will still be probed:
  compatible = "u-boot,env";
to
  compatible = "u-boot,env", "nvmem-cells";

"nvmem-cells" will tell the mtd layer to register a nvmem_device().
"u-boot,env" will tell the NVMEM that it should apply the u-boot
environment layout to the NVMEM device.

Signed-off-by: Michael Walle <redacted>
---
changes since v1:
 - none

 drivers/nvmem/layouts/Kconfig      |   8 ++
 drivers/nvmem/layouts/Makefile     |   1 +
 drivers/nvmem/layouts/u-boot-env.c | 144 +++++++++++++++++++
 drivers/nvmem/u-boot-env.c         | 218 -----------------------------
Nit: IIRC there is a MAINTAINERS entry to update as well.

Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help