Re: Similar SoCs with different CPUs and interrupt bindings
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2022-09-21 10:09:10
Also in:
linux-devicetree, linux-renesas-soc, linux-riscv, lkml
Hi Krzysztof, On Wed, Sep 21, 2022 at 11:26 AM Krzysztof Kozlowski [off-list ref] wrote:
quoted hunk ↗ jump to hunk
On 21/09/2022 11:20, Lad, Prabhakar wrote:quoted
quoted
What do you mean? Macros support string concatenation and simple arithmetic like adding numbers. I just tested it.I did try the below:diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsib/arch/arm64/boot/dts/renesas/r9a07g043.dtsi index 689aa4ba416b..0f923c276cd3 100644--- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi@@ -8,6 +8,8 @@ #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/clock/r9a07g043-cpg.h> +#define SOC_PERIPHERAL_IRQ(nr, na) GIC_SPI nr na + / { compatible = "renesas,r9a07g043"; #address-cells = <2>;@@ -128,7 +130,7 @@ ssi1: ssi@1004a000 { compatible = "renesas,r9a07g043-ssi", "renesas,rz-ssi"; reg = <0 0x1004a000 0 0x400>; - interrupts = <GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>, + interrupts = <SOC_PERIPHERAL_IRQ(330, IRQ_TYPE_LEVEL_HIGH)>, <GIC_SPI 331 IRQ_TYPE_EDGE_RISING>, <GIC_SPI 332 IRQ_TYPE_EDGE_RISING>, <GIC_SPI 333 IRQ_TYPE_EDGE_RISING>;This worked as expected, but couldn't get the arithmetic operation working. Could you please provide an example?diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi index ff6aab388eb7..0ecca775fa3f 100644 --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi@@ -8,6 +8,8 @@ #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/clock/r9a07g043-cpg.h> +#define SOC_PERIPHERAL_IRQ_NUMBER(na) (na + 32) +#define SOC_PERIPHERAL_IRQ(nr, na) GIC_SPI nr SOC_PERIPHERAL_IRQ_NUMBER(na)
#define SOC_PERIPHERAL_IRQ(nr, flags) GIC_SPI SOC_PERIPHERAL_IRQ_NUMBER(nr) flags
quoted hunk ↗ jump to hunk
/ { compatible = "renesas,r9a07g043"; #address-cells = <2>;@@ -128,7 +130,7 @@ ssi1: ssi@1004a000 { compatible = "renesas,r9a07g043-ssi", "renesas,rz-ssi"; reg = <0 0x1004a000 0 0x400>; - interrupts = <GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>, + interrupts = <SOC_PERIPHERAL_IRQ(330, IRQ_TYPE_LEVEL_HIGH)>,Or any other method like that....
Oh cool, seems like arithmetic is supported.
No idea what I did wrong last time I tried...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel