Re: [PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

On 9/5/22 04:09, Andy Shevchenko wrote:

On Mon, Sep 5, 2022 at 9:33 AM Dmitry Torokhov
[off-list ref] wrote:

quoted

I would like to stop exporting OF-specific devm_gpiod_get_from_of_node()
so that gpiolib can be cleaned a bit, so let's switch to the generic
fwnode property API.

While at it switch the rest of the calls to read properties in

it, switch

quoted

bd9576_wdt_probe() to the generic device property API as well.

...

quoted

         struct device *dev = &pdev->dev;

struct device *parent = dev->parent;

can make your code slightly neater.

...

quoted

+       count = device_property_count_u32(dev->parent, "rohm,hw-timeout-ms");
+       if (count < 0 && count != -EINVAL)
+               return count;
+
+       if (count > 0) {

quoted

+               if (count > ARRAY_SIZE(hw_margin))
+                       return -EINVAL;

Why double check? You may move it out of the (count > 0).

Two checks will always be needed, so I don't entirely see
how that would be better.

...

quoted

-       if (ret == 1)
-               hw_margin_max = hw_margin[0];

quoted

+               ret = device_property_read_u32_array(dev->parent,
+                                                    "rohm,hw-timeout-ms",
+                                                    hw_margin, count);
+               if (ret < 0)
+                       return ret;

So, only this needs the count > 0 check since below already has it implicitly.

Sorry, I don't understand this comment.

Guenter

quoted

-       if (ret == 2) {
-               hw_margin_max = hw_margin[1];
-               hw_margin_min = hw_margin[0];
+               if (count == 1)
+                       hw_margin_max = hw_margin[0];
+
+               if (count == 2) {
+                       hw_margin_max = hw_margin[1];
+                       hw_margin_min = hw_margin[0];
+               }
         }

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel