Re: [PATCH v1 09/11] regulator: bd9576: switch to using devm_fwnode_gpiod_get()
From: Andy Shevchenko <hidden>
Date: 2022-09-05 13:23:51
Also in:
dri-devel, linux-gpio, linux-pci, linux-tegra, linux-usb, linux-watchdog, lkml
On Mon, Sep 5, 2022 at 4:19 PM Matti Vaittinen [off-list ref] wrote:
On 9/5/22 13:40, Andy Shevchenko wrote:quoted
On Mon, Sep 5, 2022 at 9:33 AM Dmitry Torokhov [off-list ref] wrote:
...
quoted
quoted
+ vout_mode = device_property_read_bool(pdev->dev.parent, + "rohm,vout1-en-low");They all using parent device and you may make code neater by adding struct device *parent = pdev->dev.parent;This is a matter of personal preference. I prefer seeing pdev->dev.parent - as it is more obvious (to me) what the 'pdev' is than what 'parent' would be. I'd use the local variable only when it shortens at least one of the lines so that we avoid splitting it. After that being said - I'm not going to argue over this change either if one who is improving the driver wants to use the "helper" variable here.
And I believe the quoted one is exactly the case of what you are saying above. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel