-----Original Message-----
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Sent: 2022年8月30日 15:16
To: Hongxing Zhu <hongxing.zhu@nxp.com>; l.stach@pengutronix.de;
bhelgaas@google.com; lorenzo.pieralisi@arm.com; vkoul@kernel.org; Marcel
Ziswiler [off-list ref]; kishon@ti.com
Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
[off-list ref]; kernel@pengutronix.de; linux-phy@lists.infradead.org;
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 0/2] Fix the wrong order of phy callbacks

Hello Richard,

On 30.08.22 05:47, Hongxing Zhu wrote:

quoted

quoted

quoted

[PATCH v1 1/2] PCI: imx6: Fix the wrong order of phy_init() and
[PATCH
v1 2/2] phy: freescale: imx8m-pcie: Fix the wrong order of

This introduces an intermittent breakage. Can you squash?

Hi Ahmad:
Thanks for your comments.
Do you mean to squash this fix to the preview series?
I'm afraid that it's not easy to do that.
Because there are a lot of pci-imx6 code changes after
commit: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie

standalone phy driver").

The way I understand it, if a bisect ends up between your two patches, i.MX8M
PCIe will be broken, whereas it worked before. I thus wonder if we shouldn't
instead squash this series here into a single patch.

Yes, it's a possible case when do the bisect.
Since these changes are belong to different git repo.
It will bring maintain difficulties if these two patches are squashed into a
 single one.
It's difficult to make a choice.

Best Regards
Richard Zhu

Cheers,
Ahmad

quoted

Best Regards
Richard Zhu

quoted

quoted

--
Pengutronix e.K.                           |
|
Steuerwalder Str. 21                       |
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.

pe%2F&data=05%7C01%7Chongxing.zhu%40nxp.com%7C9950124bc71c
4e8c3c6

quoted

quoted

708da8a577051%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
79744054

quoted

quoted

06906036%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi
V2luMzIi

quoted

quoted

LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vKFXx
4XDjRsK

quoted

quoted

Kqh9aBGOmDTNGnDJuUcJhOnTf7boCEw%3D&reserved=0

ngutronix.de%2F&data=05%7C01%7Chongxing.zhu%40nxp.com%7C3277

quoted

quoted

61bac5b9407d977008da89886b15%7C686ea1d3bc2b4c6fa92cd99c5c30163

quoted

quoted

5%7C0%7C0%7C637973516254656985%7CUnknown%7CTWFpbGZsb3d8eyJ

quoted

quoted

WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7

quoted

quoted

C3000%7C%7C%7C&sdata=hasOtX77%2Fea5yLbV8C7wOfdZStF5erHOL58

quoted

quoted

Zf6ZZbo4%3D&reserved=0  |
31137 Hildesheim, Germany                  | Phone:
+49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:
+49-5121-206917-5555 |

--
Pengutronix e.K.                           |
|
Steuerwalder Str. 21                       |
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe
ngutronix.de%2F&data=05%7C01%7Chongxing.zhu%40nxp.com%7C9950
124bc71c4e8c3c6708da8a577051%7C686ea1d3bc2b4c6fa92cd99c5c301635
%7C0%7C0%7C637974405406906036%7CUnknown%7CTWFpbGZsb3d8eyJW
IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
000%7C%7C%7C&sdata=xWe0unt2cJs44zJf10h%2B3fsvxk6SuON6tDcACH
owImA%3D&reserved=0  |
31137 Hildesheim, Germany                  | Phone:
+49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:
+49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel