Re: [PATCH v1 0/2] Fix the wrong order of phy callbacks
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Date: 2022-08-30 07:15:50
Also in:
linux-pci, linux-phy, lkml
Hello Richard, On 30.08.22 05:47, Hongxing Zhu wrote:
quoted
quoted
[PATCH v1 1/2] PCI: imx6: Fix the wrong order of phy_init() and [PATCH v1 2/2] phy: freescale: imx8m-pcie: Fix the wrong order ofThis introduces an intermittent breakage. Can you squash?Hi Ahmad: Thanks for your comments. Do you mean to squash this fix to the preview series? I'm afraid that it's not easy to do that. Because there are a lot of pci-imx6 code changes after commit: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver").
The way I understand it, if a bisect ends up between your two patches, i.MX8M PCIe will be broken, whereas it worked before. I thus wonder if we shouldn't instead squash this series here into a single patch. Cheers, Ahmad
Best Regards Richard Zhuquoted
quoted
-- Pengutronix e.K. | | Steuerwalder Str. 21 | https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe ngutronix.de%2F&data=05%7C01%7Chongxing.zhu%40nxp.com%7C3277 61bac5b9407d977008da89886b15%7C686ea1d3bc2b4c6fa92cd99c5c30163 5%7C0%7C0%7C637973516254656985%7CUnknown%7CTWFpbGZsb3d8eyJ WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 C3000%7C%7C%7C&sdata=hasOtX77%2Fea5yLbV8C7wOfdZStF5erHOL58 Zf6ZZbo4%3D&reserved=0 | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel