-----Original Message-----
From: Lorenzo Pieralisi <lpieralisi@kernel.org>
Sent: 2022年8月29日 16:10
To: Hongxing Zhu <hongxing.zhu@nxp.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>; l.stach@pengutronix.de;
bhelgaas@google.com; lorenzo.pieralisi@arm.com; robh@kernel.org;
shawnguo@kernel.org; vkoul@kernel.org; alexander.stein@ew.tq-group.com;
marex@denx.de; linux-phy@lists.infradead.org; devicetree@vger.kernel.org;
linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx
[off-list ref]
Subject: Re: [PATCH v3 1/6] reset: imx7: Add the iMX8MP PCIe PHY PERST
support

On Thu, Aug 18, 2022 at 10:53:24AM +0000, Hongxing Zhu wrote:

quoted

quoted

-----Original Message-----
From: Philipp Zabel <p.zabel@pengutronix.de>
Sent: 2022年8月18日 16:51
To: Hongxing Zhu <hongxing.zhu@nxp.com>; l.stach@pengutronix.de;
bhelgaas@google.com; lorenzo.pieralisi@arm.com; robh@kernel.org;
shawnguo@kernel.org; vkoul@kernel.org;
alexander.stein@ew.tq-group.com; marex@denx.de
Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org;
linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx
[off-list ref]
Subject: Re: [PATCH v3 1/6] reset: imx7: Add the iMX8MP PCIe PHY
PERST support

Hi Richard,

On Do, 2022-08-18 at 15:02 +0800, Richard Zhu wrote:

quoted

On i.MX7/iMX8MM/iMX8MQ, the initialized default value of PERST
bit(BIT3) of SRC_PCIEPHY_RCR is 1b'1.
But i.MX8MP has one inversed default value 1b'0 of PERST bit.

And the PERST bit should be kept 1b'1 after power and clocks are stable.
So add the i.MX8MP PCIe PHY PERST support here.

the description is good now. It would be nice if this could also be
mentioned in the Reference Manual.

Please replace "add" with "fix" in the subject, as I requested earlier:
"reset: imx7: Fix i.MX8MP PCIe PHY PERST support".

And add a fixes line:

Fixes: e08672c03981 ("reset: imx7: Add support for i.MX8MP SoC")

With those two changes,
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

Hi Philipp:
Okay, would be changed in next version.

AFAICS there is still a pending comment on patch (2) but I will mark this as
"Changes requested" and wait for the next version.

Hi Lorenzo:
Thanks for your kindly help.
I had prepared the v4 version. And I also pinged Lucas privately and hope
 he can take a look at it. Thus, I can add his ack in v4 series.

Anyway, I would issue the v4 series tomorrow.
Best Regards
Richard Zhu

Lorenzo

quoted

Thanks for your review.

Best Regards
Richard Zhu

quoted

regards
Philipp

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists
.infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-kernel&data=05%7

C0

quoted

1%7Chongxing.zhu%40nxp.com%7Cd0470ce757e64e6e7c6a08da8995e689%
7C686ea1

quoted

d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637973574166682920%7CUnk
nown%7CTW

quoted

FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
CI6

quoted

Mn0%3D%7C3000%7C%7C%7C&sdata=LE4i5OQ03XV0tUo%2FWIm8L9m
Nx7ZNZMUhfpo

quoted

Lji4%2BDRM%3D&reserved=0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel