Thread (123 messages) 123 messages, 7 authors, 2022-07-26

RE: [PATCH net-next v3 27/47] net: fman: Inline several functions into initialization

From: Camelia Alexandra Groza <hidden>
Date: 2022-07-22 12:30:13
Also in: lkml, netdev

-----Original Message-----
From: Sean Anderson <redacted>
Sent: Thursday, July 21, 2022 18:34
To: Camelia Alexandra Groza <redacted>; David S . Miller
[off-list ref]; Jakub Kicinski [off-list ref]; Madalin Bucur
[off-list ref]; netdev@vger.kernel.org
Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
[off-list ref]; linux-arm-kernel@lists.infradead.org; Russell
King [off-list ref]; linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 27/47] net: fman: Inline several functions
into initialization



On 7/21/22 9:01 AM, Camelia Alexandra Groza wrote:
quoted
quoted
-----Original Message-----
From: Sean Anderson <redacted>
Sent: Saturday, July 16, 2022 1:00
To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
[off-list ref]; Madalin Bucur [off-list ref];
netdev@vger.kernel.org
Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
[off-list ref]; linux-arm-kernel@lists.infradead.org; Russell
King [off-list ref]; linux-kernel@vger.kernel.org; Sean
Anderson
quoted
quoted
[off-list ref]
Subject: [PATCH net-next v3 27/47] net: fman: Inline several functions
into
quoted
quoted
initialization

There are several small functions which weer only necessary because the
*were* typo.
Hm, I thought commit messages were supposed to be written as if the patch
hadn't
yet been applied (e.g. the current state as the patch is reviewed).
That's my understanding as well. I was pointing out this bit: "which weer only necessary ".
I assume you wanted to type "were" here.
quoted
quoted
initialization functions didn't have access to the mac private data. Now
that they do, just do things directly.

Signed-off-by: Sean Anderson <redacted>
Acked-by: Camelia Groza <redacted>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help