RE: [PATCH net-next v3 29/47] net: fman: Map the base address once
From: Camelia Alexandra Groza <hidden>
Date: 2022-07-21 13:06:11
Also in:
lkml, netdev
-----Original Message----- From: Sean Anderson <redacted> Sent: Saturday, July 16, 2022 1:00 To: David S . Miller <davem@davemloft.net>; Jakub Kicinski [off-list ref]; Madalin Bucur [off-list ref]; netdev@vger.kernel.org Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet [off-list ref]; linux-arm-kernel@lists.infradead.org; Russell King [off-list ref]; linux-kernel@vger.kernel.org; Sean Anderson [off-list ref] Subject: [PATCH net-next v3 29/47] net: fman: Map the base address once We don't need to remap the base address from the resource twice (once in mac_probe() and again in set_fman_mac_params()). We still need the resource to get the end address, but we can use a single function call to get both at once. While we're at it, use platform_get_mem_or_io and devm_request_resource to map the resource. I think this is the more "correct" way to do things here, since we use the pdev resource, instead of creating a new one. It's still a bit tricy, since we need to ensure that the resource is a
*tricky* typo
child of the fman region when it gets requested. Signed-off-by: Sean Anderson <redacted>
Acked-by: Camelia Groza <redacted> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel