On Wed, 2022-07-13 at 17:33 +0800, CK Hu wrote:

Hi, Bo-Chen:

On Tue, 2022-07-12 at 19:12 +0800, Bo-Chen Chen wrote:

quoted

From: Markus Schneider-Pargmann <msp@baylibre.com>

This patch adds a embedded displayport driver for the MediaTek
mt8195
SoC.

It supports the MT8195, the embedded DisplayPort units. It offers
DisplayPort 1.4 with up to 4 lanes.

The driver creates a child device for the phy. The child device
will
never exist without the parent being active. As they are sharing a
register range, the parent passes a regmap pointer to the child so
that
both can work with the same register range. The phy driver sets
device
data that is read by the parent to get the phy device that can be
used
to control the phy properties.

This driver is based on an initial version by
Jitao shi [off-list ref]

Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Signed-off-by: Guillaume Ranquet <redacted>
Signed-off-by: Bo-Chen Chen <redacted>
---

[snip]

quoted

+
+static void mtk_dp_aux_fill_write_fifo(struct mtk_dp *mtk_dp, u8
*buf,
+				       size_t length)
+{
+	mtk_dp_bulk_16bit_write(mtk_dp, MTK_DP_AUX_P0_3708, buf,
length);

mtk_dp_aux_fill_write_fifo() directly call mtk_dp_bulk_16bit_write(),
so I think we could just keep one of them and drop another one.

Hello CK,

mtk_dp_bulk_16bit_write() will also be used in following patches.
I want to keep the driver like this.

BRs,
Bo-Chen

Regards,
CK

quoted

+}
+

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel