Re: [PATCH V4 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings
From: Krzysztof Kozlowski <hidden>
Date: 2022-05-13 06:54:33
Also in:
linux-clk, linux-devicetree, lkml
On 13/05/2022 08:25, Jacky Huang wrote:
On 2022/5/12 下午 10:04, Krzysztof Kozlowski wrote:quoted
On 10/05/2022 05:25, Jacky Huang wrote:quoted
Add documentation to describe Nuvoton MA35D1 clock driver bindings. Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> Reviewed-by: Krzysztof Kozlowski <redacted> + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h> + + clk: clock-controller@40460200 { + compatible = "nuvoton,ma35d1-clk"; + reg = <0x0 0x40460200 0x0 0x100>;I don't think you tested your bindings. This fails. clock-names below as well. Please do not send untested code. Testing is explained here: https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.18-rc6%2Fsource%2FDocumentation%2Fdevicetree%2Fbindings%2Fwriting-schema.rst%23L111&data=05%7C01%7Cychuang3%40nuvoton.com%7C7f9b081f94a642e8b40b08da34204e53%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C637879610603173566%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kqInjscLvZpOSWtsN%2BPW3s%2BPeaK5KCD1weTH2JiHqxg%3D&reserved=0 Best regards, KrzysztofI run the test make DT_CHECKER_FLAGS=-m dt_binding_check, but not run dtbs_check.
It is the `make dt_binding_check` which fails here, so what do you mean that you run it? It cannot pass, the code is clearly not correct. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel