Re: [PATCH v7 8/8] PCI: imx6: Add the compliance tests mode support
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2022-02-24 23:54:11
Also in:
linux-pci, lkml
On Thu, Feb 24, 2022 at 07:50:09AM +0000, Hongxing Zhu wrote:
quoted
-----Original Message----- From: Bjorn Helgaas <helgaas@kernel.org> Sent: 2022年2月24日 1:40 To: Hongxing Zhu <hongxing.zhu@nxp.com> Cc: l.stach@pengutronix.de; bhelgaas@google.com; broonie@kernel.org; lorenzo.pieralisi@arm.com; jingoohan1@gmail.com; festevam@gmail.com; francesco.dolcini@toradex.com; linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx [off-list ref] Subject: Re: [PATCH v7 8/8] PCI: imx6: Add the compliance tests mode support
quoted
Is this a reference to a spec? If so, I can't tell the name of the spec, the revision, or the section number.Yes, it is a reference to a spec. How about change them to the following? PCI: imx6: Add compliance tests mode support Refer to the Chapter 3.2 System Board Signal Quality of PCI Express Architecture PHY Test Specification Revision 2.0. Signal quality tests (for example: jitter, differential eye opening and so on) can be executed with devices in the polling.compliance state. To let the device support polling.compliance state, the clocks and powers shouldn't be turned off when the probe of device driver fails. Based on CLB (Compliance Load Board) Test Fixture and so on test equipments, the PHY link would be down during the compliance tests. Refer to this scenario, add the i.MX PCIe compliance tests mode enable support, and keep the clocks and powers on, and finish the driver probe without error return. Use the "pci_imx6.compliance=1" in kernel command line to enable the compliance tests mode.
Sounds good, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel