RE: [PATCH v2 09/15] scsi: ufs: deprecate 'freq-table-hz' property
From: "Alim Akhtar" <alim.akhtar@samsung.com>
Date: 2022-02-22 16:45:18
Also in:
linux-arm-msm, linux-devicetree, linux-mediatek, linux-samsung-soc, linux-scsi, lkml
Hi Krzysztof
-----Original Message----- From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] Sent: Tuesday, February 22, 2022 8:29 PM To: Alim Akhtar <alim.akhtar@samsung.com>; Avri Altman [off-list ref]; Rob Herring [off-list ref]; Krzysztof Kozlowski [off-list ref]; Andy Gross [off-list ref]; Bjorn Andersson [off-list ref]; Wei Xu [off-list ref]; Nishanth Menon [off-list ref]; Vignesh Raghavendra [off-list ref]; Tero Kristo [off-list ref]; James E.J. Bottomley [off-list ref]; Martin K. Petersen [off-list ref]; Jan Kotas [off-list ref]; Li Wei [off-list ref]; Stanley Chu [off-list ref]; Yaniv Gardi [off-list ref]; linux-scsi@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- msm@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- soc@vger.kernel.org; linux-mediatek@lists.infradead.org Subject: [PATCH v2 09/15] scsi: ufs: deprecate 'freq-table-hz' property The 'freq-table-hz' is not correct in DT schema, because '-hz' suffix
defines
uint32 type, not an array. Therefore deprecate 'freq-table-hz' and use 'freq-table' instead.
May be once all the dts change migrate to using 'freq-table', just remove 'freq-table-hz' from driver.
quoted hunk ↗ jump to hunk
Signed-off-by: Krzysztof Kozlowski <redacted> --- drivers/scsi/ufs/ufshcd-pltfrm.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-)diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c
b/drivers/scsi/ufs/ufshcd-pltfrm.c
quoted hunk ↗ jump to hunk
index 87975d1a21c8..2b192477d158 100644--- a/drivers/scsi/ufs/ufshcd-pltfrm.c +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c@@ -47,8 +47,9 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba)if (cnt <= 0) goto out; - if (!of_get_property(np, "freq-table-hz", &len)) { - dev_info(dev, "freq-table-hz property not specified\n"); + if (!of_get_property(np, "freq-table", &len) || + !of_get_property(np, "freq-table-hz", &len)) { + dev_info(dev, "freq-table property not specified\n"); goto out; }@@ -57,7 +58,7 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba)sz = len / sizeof(*clkfreq); if (sz != 2 * cnt) { - dev_err(dev, "%s len mismatch\n", "freq-table-hz"); + dev_err(dev, "%s len mismatch\n", "freq-table"); ret = -EINVAL; goto out; }@@ -69,12 +70,16 @@ static int ufshcd_parse_clock_info(struct ufs_hba*hba) goto out; } - ret = of_property_read_u32_array(np, "freq-table-hz", + ret = of_property_read_u32_array(np, "freq-table", clkfreq, sz); if (ret && (ret != -EINVAL)) { - dev_err(dev, "%s: error reading array %d\n", - "freq-table-hz", ret); - return ret; + ret = of_property_read_u32_array(np, "freq-table-hz", + clkfreq, sz); + if (ret && (ret != -EINVAL)) { + dev_err(dev, "%s: error reading array %d\n", + "freq-table", ret); + return ret; + } } for (i = 0; i < sz; i += 2) {@@ -99,7 +104,7 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba)if (!strcmp(name, "ref_clk")) clki->keep_link_active = true; - dev_dbg(dev, "%s: min %u max %u name %s\n", "freq-table- hz", + dev_dbg(dev, "%s: min %u max %u name %s\n", "freq-table", clki->min_freq, clki->max_freq, clki->name); list_add_tail(&clki->list, &hba->clk_list_head); } -- 2.32.0
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel