Re: [PATCH] media: imx: imx8mq-mipi_csi2: Remove unneeded code
From: Muhammad Usama Anjum <hidden>
Date: 2022-01-28 17:01:14
Also in:
kernel-janitors, linux-media, linux-staging, lkml
On 1/28/22 9:23 PM, Fabio Estevam wrote:
Hi Muhammad, On Fri, Jan 28, 2022 at 10:38 AM Muhammad Usama Anjum [off-list ref] wrote:quoted
ret is constant in imx8mq_mipi_csi_pm_suspend(). This function cannot return error. Remove the return variable. Simplify other functions which are using this function. Fixes: f0c2ba1ed4ad ("media: imx: imx8mq-mipi_csi2: fix system resume")The patch looks good. I would suggest removing the Fixes tag though as this is more of a clean-up rather than a bug fix.
I'll send a V2. Thanks, Usama _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel