Re: [PATCH] media: imx: imx8mq-mipi_csi2: Remove unneeded code
From: Muhammad Usama Anjum <hidden>
Date: 2022-01-28 14:51:35
Also in:
kernel-janitors, linux-media, linux-staging, lkml
On 1/28/22 6:52 PM, Marc Kleine-Budde wrote:
On 28.01.2022 18:36:49, Muhammad Usama Anjum wrote:quoted
ret is constant in imx8mq_mipi_csi_pm_suspend(). This function cannot return error. Remove the return variable. Simplify other functions which are using this function. Fixes: f0c2ba1ed4ad ("media: imx: imx8mq-mipi_csi2: fix system resume") Signed-off-by: Muhammad Usama Anjum <redacted> --- drivers/staging/media/imx/imx8mq-mipi-csi2.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-)diff --git a/drivers/staging/media/imx/imx8mq-mipi-csi2.c b/drivers/staging/media/imx/imx8mq-mipi-csi2.c index 3b9fa75efac6b..c992b845e63d1 100644 --- a/drivers/staging/media/imx/imx8mq-mipi-csi2.c +++ b/drivers/staging/media/imx/imx8mq-mipi-csi2.c[...]quoted
static int imx8mq_mipi_csi_pm_resume(struct device *dev)@@ -742,15 +739,12 @@ static int __maybe_unused imx8mq_mipi_csi_suspend(struct device *dev) { struct v4l2_subdev *sd = dev_get_drvdata(dev); struct csi_state *state = mipi_sd_to_csi2_state(sd); - int ret; - ret = imx8mq_mipi_csi_pm_suspend(dev); - if (ret) - return ret; + imx8mq_mipi_csi_pm_suspend(dev); state->state |= ST_SUSPENDED;what about this flag?
Now that no error is possible inside this function. The state is being updated each time. This seems correct logically. Thanks, Usama _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel