Hi AngeloGioacchino,

Sorry for the late reply and thanks for the advice.

On Fri, 2022-01-07 at 15:33 +0100, AngeloGioacchino Del Regno wrote:

Il 07/01/22 10:51, Roger Lu ha scritto:

quoted

The Smart Voltage Scaling(SVS) engine is a piece of hardware
which calculates suitable SVS bank voltages to OPP voltage table.
Then, DVFS driver could apply those SVS bank voltages to PMIC/Buck
when receiving OPP_EVENT_ADJUST_VOLTAGE.

Signed-off-by: Roger Lu <redacted>
---
  drivers/soc/mediatek/Kconfig   |   10 +
  drivers/soc/mediatek/Makefile  |    1 +
  drivers/soc/mediatek/mtk-svs.c | 1446 ++++++++++++++++++++++++++++++++
  3 files changed, 1457 insertions(+)
  create mode 100644 drivers/soc/mediatek/mtk-svs.c

[snip]

quoted

+
+struct svs_platform_data {
+	char *name;
+	struct svs_bank *banks;
+	bool (*efuse_parsing)(struct svs_platform *svsp);
+	unsigned long irqflags;
+	const u32 *regs;
+	u32 bank_max;
+	int (*probe)(struct svs_platform *svsp);
+};
+

Please move the definition of struct svs_platform_data at the beginning of
the file for increased readability.

Okay. I'll move them at the beginning of the file in the next patch.

With that done,

Reviewed-by: AngeloGioacchino Del Regno <
angelogioacchino.delregno@collabora.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel