Hi,Andy

On 2021/12/14 下午7:57, Andy Shevchenko wrote:

On Tue, Dec 14, 2021 at 6:27 AM Qianggui Song [off-list ref] wrote:

quoted

Add new pinctrl driver for Amlogic's Meson-S4 SoC which share the
same register laytout as the previous Meson-A1.

layout

...

awkward

quoted

+config PINCTRL_MESON_S4
+       tristate "Meson s4 Soc pinctrl driver"
+       depends on ARM64
+       select PINCTRL_MESON_AXG_PMX
+       default y

Why is it needed on other (non-MESON_S4) SoCs?

...

to keep consistent with previous chips configuration, maybe another  
patch set to   remove all default y

for all previous SoCs.

quoted

+static const char * const i2c1_groups[] = {
+       "i2c1_sda_c", "i2c1_scl_c",
+       "i2c1_sda_d", "i2c1_scl_d",
+       "i2c1_sda_h", "i2c1_scl_h",
+       "i2c1_sda_x", "i2c1_scl_x"

In this and all the rest similar cases leave a comma.

Okay.

quoted

+};

...

quoted

+static const struct of_device_id meson_s4_pinctrl_dt_match[] = {
+       {
+               .compatible = "amlogic,meson-s4-periphs-pinctrl",
+               .data = &meson_s4_periphs_pinctrl_data,
+       },
+       { },

When it's a terminator entry, no comma is needed.

will fix it  in next patch

quoted

+};

...

quoted

+static struct platform_driver meson_s4_pinctrl_driver = {
+       .probe  = meson_pinctrl_probe,
+       .driver = {
+               .name   = "meson-s4-pinctrl",
+               .of_match_table = meson_s4_pinctrl_dt_match,
+       },
+};
+
+module_platform_driver(meson_s4_pinctrl_driver);

Swap above two lines, first module_...() followed by a blank line.

Okay.

quoted

+MODULE_LICENSE("Dual BSD/GPL");

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel