On 2021/12/31 6:44, Martin Blumenstingl wrote:

[ EXTERNAL EMAIL ]

On Thu, Dec 30, 2021 at 11:22 AM Yu Tu [off-list ref] wrote:
[...]

quoted

         val = readl(port->membase + AML_UART_CONTROL);
-       val &= ~AML_UART_RX_EN;
+       val &= ~(AML_UART_RX_EN | AML_UART_TX_EN);
         val &= ~(AML_UART_RX_INT_EN | AML_UART_TX_INT_EN);
         writel(val, port->membase + AML_UART_CONTROL);

This looks fine to me but I think it would be good to Cc the author of
commit 855ddcab352c15 ("ARM: meson: serial: only disable tx irq on
stop")
The meson_uart driver which Carlo added eight years ago did clear
AML_UART_TX_EN here, but it was changed with the commit I mentioned
above.

I'm going to delete this change this time. Because there is no bug at 
present, if this is a bug encountered later, i will prepare to submit 
this change.

Best regards,
Martin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel