Hi Greg,

On Thu, Dec 30, 2021 at 1:29 PM Greg Kroah-Hartman
[off-list ref] wrote:
[...]

quoted

 static void meson_uart_release_port(struct uart_port *port)
 {
-     devm_iounmap(port->dev, port->membase);
-     port->membase = NULL;
-     devm_release_mem_region(port->dev, port->mapbase, port->mapsize);
+     /* nothing to do */
 }

Are you sure a release call like this can be "empty"?  That goes against
the normal way the driver model works.  If it is empty, why have it at
all?

In patch #4 from this series some logic is added here again.
I can think of three options here (in no particular order):
- keep this patch as-is
- remove the empty function from this patch and it back in patch #4
from this series
- try to split some of the logic from patch #4 so the relevant
clk_prepare_enable/clk_disable_unpepare calls are added here (meaning
that this function has logic inside it at all times throughout this
series)
- (if you have another suggestion then please let us know)


Best regards,
Martin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel