Thread (16 messages) 16 messages, 6 authors, 2022-01-03

Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt

From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date: 2021-12-26 10:03:51
Also in: linux-i2c, linux-renesas-soc, lkml

On Sun, Dec 26, 2021 at 8:41 AM Andy Shevchenko
[off-list ref] wrote:
On Sun, Dec 26, 2021 at 1:45 AM Prabhakar Mahadev Lad
[off-list ref] wrote:
quoted
quoted
On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar [off-list ref] wrote:
...
quoted
quoted
quoted
+       if (np) {
Same comments as per your other patches, i.e.
Why is this check here?
Because the interrupt resource has range of interrupts in one IRQ resource [0]. Let me know if there is any other alternative way to avoid such case.
Shouldn't be fixed in platform_get_irq_optional() to return IRQ by
index for all cases?
Sorry, I don't get you here. Wasn't your earlier comment for np check?

Cheers,
Prabhakar

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help