Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt
From: Andy Shevchenko <hidden>
Date: 2021-12-26 08:41:34
Also in:
linux-i2c, linux-renesas-soc, lkml
On Sun, Dec 26, 2021 at 1:45 AM Prabhakar Mahadev Lad [off-list ref] wrote:
quoted
On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar [off-list ref] wrote:
...
quoted
quoted
+ if (np) {Same comments as per your other patches, i.e. Why is this check here?Because the interrupt resource has range of interrupts in one IRQ resource [0]. Let me know if there is any other alternative way to avoid such case.
Shouldn't be fixed in platform_get_irq_optional() to return IRQ by index for all cases?
[0] https://elixir.bootlin.com/linux/v5.16-rc6/source/arch/sh/kernel/cpu/sh4a/setup-sh7724.c#L454
-- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel