-----Original Message-----
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Sent: Tuesday, November 30, 2021 7:41 AM
To: Neal Liu <neal_liu@aspeedtech.com>; Felipe Balbi <balbi@kernel.org>;
Greg Kroah-Hartman [off-list ref]; Joel Stanley
[off-list ref]; Andrew Jeffery [off-list ref]; Cai Huoqing
[off-list ref]; Tao Ren [off-list ref]; Julia Lawall
[off-list ref]; kernel test robot [off-list ref]; Sasha Levin
[off-list ref]; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org
Cc: BMC-SW <redacted>
Subject: Re: [PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor

On Fri, 2021-11-26 at 19:09 +0800, Neal Liu wrote:

quoted

@@ -417,10 +435,9 @@ enum std_req_rc ast_vhub_std_hub_request(struct

ast_vhub_ep *ep,

 		/* GET/SET_CONFIGURATION */
 	case DeviceRequest | USB_REQ_GET_CONFIGURATION:
-		return ast_vhub_simple_reply(ep, 1);
+		return ast_vhub_simple_reply(ep, vhub->current_config);
 	case DeviceOutRequest | USB_REQ_SET_CONFIGURATION:
-		if (wValue != 1)
-			return std_req_stall;
+		vhub->current_config = wValue;
 		return std_req_complete;

This is odd.. why should we support arbitrary SET_CONFIGURATION for configs
we don't support ?

Otherwise looks good.

Cheers,
Ben.

This is unnecessary...
I'll remove it in next patch.
Thanks

-Neal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel