Re: [PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2021-11-29 23:47:45
Also in:
linux-aspeed, linux-usb, lkml
On Fri, 2021-11-26 at 19:09 +0800, Neal Liu wrote:
quoted hunk ↗ jump to hunk
@@ -417,10 +435,9 @@ enum std_req_rc ast_vhub_std_hub_request(struct ast_vhub_ep *ep, /* GET/SET_CONFIGURATION */ case DeviceRequest | USB_REQ_GET_CONFIGURATION: - return ast_vhub_simple_reply(ep, 1); + return ast_vhub_simple_reply(ep, vhub->current_config); case DeviceOutRequest | USB_REQ_SET_CONFIGURATION: - if (wValue != 1) - return std_req_stall; + vhub->current_config = wValue; return std_req_complete;
This is odd.. why should we support arbitrary SET_CONFIGURATION for configs we don't support ? Otherwise looks good. Cheers, Ben. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel