Thread (27 messages) 27 messages, 4 authors, 2021-11-30

Re: [PATCH 4/8] tty: serial: samsung: Remove USI initialization

From: Sam Protsenko <semen.protsenko@linaro.org>
Date: 2021-11-28 17:06:05
Also in: linux-devicetree, linux-i2c, linux-samsung-soc, linux-serial, linux-spi, lkml

On Sun, 28 Nov 2021 at 18:26, Sam Protsenko [off-list ref] wrote:
On Sun, 28 Nov 2021 at 16:28, Greg Kroah-Hartman
[off-list ref] wrote:
quoted
On Sun, Nov 28, 2021 at 12:32:49AM +0200, Sam Protsenko wrote:
quoted
USI control is now extracted to dedicated USIv2 driver. Remove USI
related code from serial driver to avoid conflicts and code duplication.
What conflicts?
There might be possible conflicts when accessing the same USI register
from both serial driver and USIv2 driver. Also there will be conflicts
when trying to access the same I/O address space in those both
drivers.
quoted
What duplication?  All you did here was delete code.
It's all explained in [PATCH 0/8], but long story short, I've added
USIv2 driver (in this series) which handles the code that's removed
from serial driver in this patch.
In other words, this code is now present here: [1]. But of course
USIv2 driver must be applied first, and then this patch (removing the
same code from serial driver). That's why it's in the same series and
it's placed after USIv2 driver ([PATCH 3/8]).

[1] https://patchwork.kernel.org/project/linux-samsung-soc/patch/20211127223253.19098-4-semen.protsenko@linaro.org/
quoted
confused,

greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help