Thread (29 messages) 29 messages, 6 authors, 2021-12-09

Re: [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2021-11-19 22:54:35
Also in: amd-gfx, dri-devel, intel-gfx, linux-arm-msm, lkml

On Fri, 19 Nov 2021 15:46:31 -0700
jim.cromie@gmail.com wrote:

quoted
So I could see us supporting subsystem specific trace buffer output
via dynamic debug here. We could add new dev_debug() variants that
allow say a trace buffer to be supplied. So in that way subsystems
could 'opt-out' of having their data put into the global trace buffer.
And perhaps some subsystems we would want to allow output to both
buffers? The subsystem specific one and the global one?
 
 * trace_array_printk - Print a message to a specific instance
 * @tr: The instance trace_array descriptor
 * @ip: The instruction pointer that this is called from.
 * @fmt: The format to print (printf format)
 *

what happens when @tr == NULL ?
It does nothing, but perhaps crash the kernel.
It could allow up-flow of events to the global instance
Absolutely not!

Then it's just a reimplementation of trace_printk(). Which I refuse to
have.

Nothing should just dump to the main instance. Once we allow that, then
everyone will be dumping there and you will no longer be able to trace
anything because it will be filled with noise.

What is allowed is an event that acts like a trace_printk() but is an
event, which you can turn off (have default off), and even pick which
instance to go to.
quoted
Thanks,

-Jason

 
So I wonder, is there any conceptual utility to this ?

echo 1 > instances/foo/filter_up  # enable event upflow (or query-time merging?)

Maybe enabling this causes other files (the ones missing from
instances/foo) to magically appear
so all those filtering capacities also appear.

I've been busy doing other things so I haven't been keeping up with
this thread (which I need to go back and read). Perhaps it was already
stated, but I don't know why you want that.

trace-cmd can read several instances (including the top level one) and
interleave them nicely, if that is what you are looking for. So can
KernelShark.

-- Steve

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help