Thread (23 messages) 23 messages, 3 authors, 2021-11-10

Re: [PATCH v2 7/8] gpiolib: remove gpio_to_chip

From: Arnd Bergmann <arnd@kernel.org>
Date: 2021-11-09 10:54:41
Also in: linux-gpio, lkml

On Tue, Nov 9, 2021 at 11:32 AM Andy Shevchenko
[off-list ref] wrote:
quoted
 #ifdef CONFIG_GPIOLIB
I'm wondering if we need this ifdeffery at all.
We don't need it for the first half (gpio_set_value, gpio_direction_input, ...),
which could just be unconditional wrappers around the gpiod versions.
Removing that #ifdef would require always including linux/gpio/consumer.h
here, so we'd no longer get a build failure when a driver uses gpiod_*
without including that directly (when GPIOLIB is disabled).

I actually had a patch in my series to do this, but dropped that because
the second half (gpio_request/gpio_free/...) does need the #ifdef

         Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help